linux-kernel - Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c56c556d-e9f4-16f6-b4b6-a073e2443346@linaro.org>
Date:   Fri, 28 Sep 2018 12:29:21 -0500
From:   Alex Elder <elder@...aro.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Niklas Cassel <niklas.cassel@...aro.org>, andy.gross@...aro.org,
        david.brown@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

On 09/28/2018 12:21 PM, Bjorn Andersson wrote:
>> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
>> change that to select it instead but I still think this entry
>> should be changed.

I was thinking one of two changes:
- Add the prompt string (which I suggested)
- Don't add the prompt, but remove the help and/or add a comment to
  indicate that the lack of prompt is intentional (because it really
  looked like an oversight to me)

I don't really care though; I'll change my code to select it
rather than depend on it.

> Why do you say it needs to change? I tested this by just adding a
> "select QCOM_QMI_HELPERS" in my client drivers.
> 
>> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
>> also depends on--rather than selects--QCOM_QMI_HELPERS.
>>
> That's wrong.

Maybe someone else should fix this, but I can do it if you like (and
if that's the case, say so).

					-Alex