linux-kernel - Re: [PATCH] x86: init: Remove raw kernel pointer from printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Sep 2018 21:48:40 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jeff loughlin <loughlinjd@...il.com>
cc:     mingo@...hat.com, bp@...en8.de, hpa@...or.com, x86@...nel.org,
        pombredanne@...b.com, brijesh.singh@....com,
        thomas.lendacky@....com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: init: Remove raw kernel pointer from printk

Jeff, 

On Fri, 28 Sep 2018, Jeff loughlin wrote:

> From: Jeff Loughlin <loughlinjd@...il.com>
> 
>     printk message in set_real_mode_mem() contains a raw kernel pointer, which printk rightly changes to (ptrval).

Please format your changelog properly next time. Left aligned and line
breaks around 78 characters.

>     This is useless in the dmesg log and should be removed.

Agreed, (ptrval) is pretty useless, but this is a debug printk and the real
address is not useless for debugging, so just removing it is not
necessarily the best solution.

>     Signed-off-by: Jeff Loughlin <loughlinjd@...il.com>
> ---
>  arch/x86/realmode/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c
> index d101058..d76a138 100644
> --- a/arch/x86/realmode/init.c
> +++ b/arch/x86/realmode/init.c
> @@ -20,8 +20,8 @@ void __init set_real_mode_mem(phys_addr_t mem, size_t size)
>  	void *base = __va(mem);
>  
>  	real_mode_header = (struct real_mode_header *) base;
> -	printk(KERN_DEBUG "Base memory trampoline at [%p] %llx size %zu\n",
> -	       base, (unsigned long long)mem, size);
> +	printk(KERN_DEBUG "Base memory trampoline at %llx size %zu\n",
> +	       (unsigned long long)mem, size);

Please check your patches with scripts/checkpatch.pl next time. It would
have told you to change that printk(KERN_DEBUG) to pr_debug()

Thanks,

	tglx