linux-kernel - [tip:timers/core] tick/broadcast: Remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-dc6253108f0fbff4a634055d5b8a91958ec2af81@git.kernel.org>
Date:   Fri, 28 Sep 2018 13:33:52 -0700
From:   tip-bot for Peng Hao <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        peng.hao2@....com.cn, mingo@...nel.org, hpa@...or.com
Subject: [tip:timers/core] tick/broadcast: Remove redundant check

Commit-ID:  dc6253108f0fbff4a634055d5b8a91958ec2af81
Gitweb:     https://git.kernel.org/tip/dc6253108f0fbff4a634055d5b8a91958ec2af81
Author:     Peng Hao <peng.hao2@....com.cn>
AuthorDate: Fri, 28 Sep 2018 12:03:28 -0400
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 28 Sep 2018 22:29:35 +0200

tick/broadcast: Remove redundant check

tick_device_is_functional() is called early in tick_broadcast_control(), so
no need to call it again later.

Signed-off-by: Peng Hao <peng.hao2@....com.cn>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: fweisbec@...il.com
Link: https://lkml.kernel.org/r/1538150608-2599-1-git-send-email-penghao122@sina.com.cn

---
 kernel/time/tick-broadcast.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index aa2094d5dd27..be0aac2b4300 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -400,8 +400,6 @@ void tick_broadcast_control(enum tick_broadcast_mode mode)
 		if (tick_broadcast_forced)
 			break;
 		cpumask_clear_cpu(cpu, tick_broadcast_on);
-		if (!tick_device_is_functional(dev))
-			break;
 		if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_mask)) {
 			if (tick_broadcast_device.mode ==
 			    TICKDEV_MODE_PERIODIC)