linux-kernel - RE: [PATCH v3] usb: hub: try old enumeration scheme first for high speed devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <678F3D1BB717D949B966B68EAEB446ED0CA25F3F@dggemm526-mbx.china.huawei.com>
Date:   Fri, 28 Sep 2018 03:24:31 +0000
From:   "Zengtao (B)" <prime.zeng@...ilicon.com>
To:     Greg KH <gregkh@...uxfoundation.org>, Roger Quadros <rogerq@...com>
CC:     "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "mathias.nyman@...ux.intel.com" <mathias.nyman@...ux.intel.com>,
        "drinkcat@...omium.org" <drinkcat@...omium.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "drake@...lessm.com" <drake@...lessm.com>,
        "ravisadineni@...omium.org" <ravisadineni@...omium.org>,
        "joe@...ches.com" <joe@...ches.com>,
        "Jonathan Corbet" <corbet@....net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Marc Zyngier" <marc.zyngier@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Thymo van Beers <thymovanbeers@...il.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        "David Rientjes" <rientjes@...gle.com>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v3] usb: hub: try old enumeration scheme first for high
 speed devices

Hi greg:

Sorry for the late response, I have applied the tags and resend, please receive it and check

Thx
Zengtao 

>-----Original Message-----
>From: Greg KH [mailto:gregkh@...uxfoundation.org]
>Sent: Thursday, September 20, 2018 6:38 PM
>To: Roger Quadros <rogerq@...com>
>Cc: Zengtao (B) <prime.zeng@...ilicon.com>; stern@...land.harvard.edu;
>mathias.nyman@...ux.intel.com; drinkcat@...omium.org;
>felipe.balbi@...ux.intel.com; drake@...lessm.com;
>ravisadineni@...omium.org; joe@...ches.com; Jonathan Corbet
><corbet@....net>; Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar
><mingo@...nel.org>; Rafael J. Wysocki <rafael.j.wysocki@...el.com>;
>Marc Zyngier <marc.zyngier@....com>; Kai-Heng Feng
><kai.heng.feng@...onical.com>; Thymo van Beers
><thymovanbeers@...il.com>; Frederic Weisbecker
><frederic@...nel.org>; Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>;
>David Rientjes <rientjes@...gle.com>; Mike Looijmans
><mike.looijmans@...ic.nl>; linux-doc@...r.kernel.org;
>linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org
>Subject: Re: [PATCH v3] usb: hub: try old enumeration scheme first for
>high speed devices
>
>On Mon, Aug 20, 2018 at 09:55:49AM +0300, Roger Quadros wrote:
>> On 20/08/18 13:04, Zeng Tao wrote:
>> > The new scheme is required just to support legacy low and full-speed
>> > devices. For high speed devices, it will slower the enumeration speed.
>> > So in this patch we try the "old" enumeration scheme first for high
>> > speed devices, and this is what Windows does since Windows 8.
>> >
>> > Signed-off-by: Zeng Tao <prime.zeng@...ilicon.com>
>>
>> You need to add Alan's Ack here. I don't think you need to resend
>though.
>>
>> Reviewed-by: Roger Quadros <rogerq@...com>
>
>Please resend, I need his ack here :)
>
>thanks,
>
>greg k-h