linux-kernel - Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Sep 2018 16:32:33 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     linus.walleij@...aro.org, Anders Roxell <anders.roxell@...aro.org>
Cc:     lgirdwood@...il.com, broonie@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        jmkrzyszt@...il.com, shc_work@...l.ru, haojian.zhuang@...il.com,
        aaro.koskinen@....fi, rppt@...ux.vnet.ibm.com,
        robert.jarzmik@...e.fr, philipp.zabel@...il.com, zonque@...il.com,
        marc.zyngier@....com, jacopo@...ndi.org, geert+renesas@...der.be,
        rmk+kernel@...linux.org.uk, Tom Gall <tom.gall@...aro.org>
Subject: Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

On Thu, Sep 6, 2018 at 6:01 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> As we augmented the regulator core to accept a GPIO descriptor instead
> of a GPIO number, we can augment the fixed GPIO regulator to look up
> and pass that descriptor directly from device tree or board GPIO
> descriptor look up tables.
>
> Some boards just auto-enumerate their fixed regulator platform devices
> and I have assumed they get names like "fixed-regulator.0" but it's
> pretty hard to guess this. I need some testing from board maintainers to
> be sure. Other boards are straight forward, using just plain
> "fixed-regulator" (ID -1) or "fixed-regulator.1" hammering down the
> device ID.

Hey Linus,
  Anders recently noted a regression in -next when running HiKey,
where USB fails to function.  I took a look and could reproduce this
as well, and after some unsuccessful muddling about in the usb
changes, I bisected it down to your commit here (specifically
efdfeb079cc3 in -next).

I'm not sure exactly why this would cause trouble, but I suspect it
has something to do w/ the cable-detect OTG to host-hub switch on the
HiKey.

Anyway, I just wanted to raise this with you so it can get sorted out
before that patch hits mainline.

thanks
-john