linux-kernel - Re: [PATCH] input: sun4i-lradc: Convert to using %pOFn instead of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180928235916.GA182370@dtor-ws>
Date:   Fri, 28 Sep 2018 16:59:16 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] input: sun4i-lradc: Convert to using %pOFn instead of
 device_node.name

On Mon, Aug 27, 2018 at 08:52:24PM -0500, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
> 
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Maxime Ripard <maxime.ripard@...tlin.com>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Applied, thank you.

> ---
>  drivers/input/keyboard/sun4i-lradc-keys.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
> index a37c172452e6..57272df34cd5 100644
> --- a/drivers/input/keyboard/sun4i-lradc-keys.c
> +++ b/drivers/input/keyboard/sun4i-lradc-keys.c
> @@ -185,19 +185,19 @@ static int sun4i_lradc_load_dt_keymap(struct device *dev,
>  
>  		error = of_property_read_u32(pp, "channel", &channel);
>  		if (error || channel != 0) {
> -			dev_err(dev, "%s: Inval channel prop\n", pp->name);
> +			dev_err(dev, "%pOFn: Inval channel prop\n", pp);
>  			return -EINVAL;
>  		}
>  
>  		error = of_property_read_u32(pp, "voltage", &map->voltage);
>  		if (error) {
> -			dev_err(dev, "%s: Inval voltage prop\n", pp->name);
> +			dev_err(dev, "%pOFn: Inval voltage prop\n", pp);
>  			return -EINVAL;
>  		}
>  
>  		error = of_property_read_u32(pp, "linux,code", &map->keycode);
>  		if (error) {
> -			dev_err(dev, "%s: Inval linux,code prop\n", pp->name);
> +			dev_err(dev, "%pOFn: Inval linux,code prop\n", pp);
>  			return -EINVAL;
>  		}
>  
> -- 
> 2.17.1
> 

-- 
Dmitry