linux-kernel - Re: [PATCH v6] selftests: add headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y3bmte9l.fsf@concordia.ellerman.id.au>
Date:   Fri, 28 Sep 2018 14:52:22 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Anders Roxell <anders.roxell@...aro.org>,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        shuah@...nel.org, bamv2005@...il.com, brgl@...ev.pl,
        pbonzini@...hat.com, akpm@...ux-foundation.org,
        rppt@...ux.vnet.ibm.com, aarcange@...hat.com
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
        Anders Roxell <anders.roxell@...aro.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v6] selftests: add headers_install to lib.mk

[ + linuxppc-dev ]

Anders Roxell <anders.roxell@...aro.org> writes:
> If the kernel headers aren't installed we can't build all the tests.
> Add a new make target rule 'khdr' in the file lib.mk to generate the
> kernel headers and that gets include for every test-dir Makefile that
> includes lib.mk If the testdir in turn have its own sub-dirs the
> top_srcdir needs to be set to the linux-rootdir to be able to generate
> the kernel headers.
>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> Reviewed-by: Fathi Boudra <fathi.boudra@...aro.org>
> ---
>
> I sent this (v5) a month ago and wondered if it got lost. Resending
> unchanged.
>
> Cheers,
> Anders
>
>  Makefile                                           | 14 +-------------
>  scripts/subarch.include                            | 13 +++++++++++++
>  tools/testing/selftests/android/Makefile           |  2 +-
>  tools/testing/selftests/android/ion/Makefile       |  2 ++
>  tools/testing/selftests/futex/functional/Makefile  |  1 +
>  tools/testing/selftests/gpio/Makefile              |  7 ++-----
>  tools/testing/selftests/kvm/Makefile               |  7 ++-----
>  tools/testing/selftests/lib.mk                     | 12 ++++++++++++
>  tools/testing/selftests/net/Makefile               |  1 +
>  .../selftests/networking/timestamping/Makefile     |  1 +
>  tools/testing/selftests/vm/Makefile                |  4 ----
>  11 files changed, 36 insertions(+), 28 deletions(-)
>  create mode 100644 scripts/subarch.include

This broke all the powerpc selftests :(

Why did it go in at rc5?

cheers