linux-kernel - Re: [PATCH v3 1/2] printk: Fix panic caused by passing log_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180929082619.GA582@tigerII.localdomain>
Date:   Sat, 29 Sep 2018 17:26:19 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     zhe.he@...driver.com
Cc:     pmladek@...e.com, sergey.senozhatsky@...il.com,
        rostedt@...dmis.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] printk: Fix panic caused by passing log_buf_len
 to command line

On (09/28/18 22:46), zhe.he@...driver.com wrote:
> This patch adds a check to prevent the panic and a check to report if someone is
> setting it over 4G.

OK, He Zhe, you are almost there.
Let's do the series the following way:

- four patches
- each change goes into a separate patch
- the first two patches Cc stable


patch #0   Cc stable

---
	unsigned int size;

	if (!str)
		return -EINVAL;
	size = memparse(str, &str);

---


patch #1   Cc stable

---

        len = sprintf(text,
                      "** %llu printk messages dropped **\n",
                      log_first_seq - console_seq);

---


=====================================================================

patch #2

---

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

---


patch #3

---

      if (size > UINT_MAX) {
              size = UINT_MAX;
              pr_err("log_buf over 4G is not supported.\n");
      }

      ...
---

	-ss