linux-kernel - Re: [PATCH] Staging: vt6656: baseband.c: fixed unnecessary paranthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Sep 2018 02:34:39 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shubham Singh <dhoni.singh094@...il.com>
Cc:     forest@...ttletooquite.net, devel@...ver.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vt6656: baseband.c: fixed unnecessary
 paranthesis

On Sat, Sep 29, 2018 at 02:28:54PM +0530, Shubham Singh wrote:
> From: shubhsherl <dhoni.singh094@...il.com>
> 
> Fixed a coding line issue.
> 
> Signed-off-by: shubhsherl <dhoni.singh094@...il.com>

We need a real name please.

> ---
>  drivers/staging/vt6656/baseband.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
> index b29ba237fa29..540cc9eafd07 100644
> --- a/drivers/staging/vt6656/baseband.c
> +++ b/drivers/staging/vt6656/baseband.c
> @@ -382,8 +382,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
>  
>  	dev_dbg(&priv->usb->dev, "RF Type %d\n", priv->rf_type);
>  
> -	if ((priv->rf_type == RF_AL2230) ||
> -	    (priv->rf_type == RF_AL2230S)) {
> +	if (priv->rf_type == RF_AL2230 ||
> +	    priv->rf_type == RF_AL2230S) {

Huh?  What coding style issue caused this?  The original code is fine,
don't you agree?  This type of change just makes it harder to work with
over time (hint, you have to go look up the order of operations all the
time...)

thanks

greg k-h