linux-kernel - Re: [PATCH] dts: sun8i-h3: add sy8106a to orange pi plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180929131617.GA7940@carbon.kippendief.biz>
Date:   Sat, 29 Sep 2018 15:16:17 +0200
From:   Jorik Jonker <jorik@...pendief.biz>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, wens@...e.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH] dts: sun8i-h3: add sy8106a to orange pi plus

Hi,

On Fri, Sep 28, 2018 at 03:55:16PM +0200, Maxime Ripard wrote:
>The prefix of your commit title should be "ARM: dts: ..."

Sure, will fix it in v2.

>> I have tested this on two Orange Pi Plus boards, and they run stable
>> across a range of voltages (and frequencies).
>
>How was this tested?

Basically using intermittent cpuburn runs and monitor freq/voltage/temp.  
I've included a description of my test in the v2 commit log.

>> +		/*
>> +		 * The datasheet uses 1.1V as the minimum value of VDD-CPUX,
>> +		 * however both the Armbian DVFS table and the official one
>> +		 * have operating points with voltage under 1.1V, and both
>> +		 * DVFS table are known to work properly at the lowest
>> +		 * operating point.
>> +		 *
>> +		 * Use 1.0V as the minimum voltage instead.
>> +		 */
>
>There's not much point to that comment, since it's been that way for
>all the other SoCs from Allwinner. However, that would be great to
>have it in the commit log.

Totally agree, but I thought: there must be a good reason this text is 
in the PC dts, so let's put it in the Plus dts as well. I've moved it 
from the patch to the log in the v2 patch, which I will send right away.

Thanks for reviewing!

Jorik