linux-kernel - RE: [PATCH net-next 00/10] Cleanups, minor additions & fixes for HNS3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93BF10CA1@FRAEML521-MBX.china.huawei.com>
Date:   Sat, 29 Sep 2018 15:09:18 +0000
From:   Salil Mehta <salil.mehta@...wei.com>
To:     David Miller <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>
CC:     "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "lipeng (Y)" <lipeng321@...wei.com>,
        "mehta.salil@...src.net" <mehta.salil@...src.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>
Subject: RE: [PATCH net-next 00/10] Cleanups, minor additions & fixes for
 HNS3 driver

Hi David/Eric,
I missed to include a patch during a patch-set submission which caused some build errors. 
I have fixed that in V2 version of this patch-set. 

The only change between V1-->V2 is in patch:
 "hns3: Add serdes parallel inner  loopback support"

This also fixes the spelling mistake identified by David and error shown
by Eric Dumazet.

Sorry for any in convenience caused.

Thanks & regards
Salil
> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Friday, September 28, 2018 7:56 PM
> To: David Miller <davem@...emloft.net>; Salil Mehta
> <salil.mehta@...wei.com>
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@...wei.com>; lipeng (Y)
> <lipeng321@...wei.com>; mehta.salil@...src.net; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Linuxarm <linuxarm@...wei.com>
> Subject: Re: [PATCH net-next 00/10] Cleanups, minor additions & fixes
> for HNS3 driver
> 
> 
> 
> On 09/28/2018 10:38 AM, David Miller wrote:
> > From: Salil Mehta <salil.mehta@...wei.com>
> > Date: Wed, 26 Sep 2018 19:28:30 +0100
> >
> >> This patch-set contains cleans-ups, minor changes and fixes to the
> HNS3 driver.
> >
> > Series applied, thank you.
> >
> 
> Something seems wrong
> 
> # git grep -n HNS3_SELF_TEST_TYPE_NUM
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278: int
> st_param[HNS3_SELF_TEST_TYPE_NUM][2];
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:316: for (i = 0; i <
> HNS3_SELF_TEST_TYPE_NUM; i++) {
> 
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function
> 'hns3_self_test':
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: error:
> 'HNS3_SELF_TEST_TYPE_NUM' undeclared (first use in this function)
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: note: each
> undeclared identifier is reported only once for each function it
> appears in
> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:6: error: unused
> variable 'st_param' [-Werror=unused-variable]