linux-kernel - Re: [PATCH] modpost: remove leftover symbol prefix handling for module device table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bm8giy9l.fsf@rustcorp.com.au>
Date:   Sat, 29 Sep 2018 16:30:22 +0930
From:   Rusty Russell <rusty@...tcorp.com.au>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kernel@...r.kernel.org, Jessica Yu <jeyu@...nel.org>
Subject: Re: [PATCH] modpost: remove leftover symbol prefix handling for module device table

Please send this to the module maintainer (CC'd).

Masahiro Yamada <yamada.masahiro@...ionext.com> writes:
> Blackfin and metag were the only architectures that prefix symbols with
> an underscore.  They were removed by commit 4ba66a976072 ("arch: remove
> blackfin port"), commit bb6fb6dfcc17 ("metag: Remove arch/metag/"),
> respectively.
>
> It is no longer necessary to handle <prefix> part of module device
> table symbols.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  scripts/mod/file2alias.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 7be4369..ba4ebc4 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -1415,11 +1415,10 @@ void handle_moddevtable(struct module *mod, struct elf_info *info,
>  	if (ELF_ST_TYPE(sym->st_info) != STT_OBJECT)
>  		return;
>  
> -	/* All our symbols are of form <prefix>__mod_<name>__<identifier>_device_table. */
> -	name = strstr(symname, "__mod_");
> -	if (!name)
> +	/* All our symbols are of form __mod_<name>__<identifier>_device_table. */
> +	if (strncmp(symname, "__mod_", strlen("__mod_")))
>  		return;
> -	name += strlen("__mod_");
> +	name = symname + strlen("__mod_");
>  	namelen = strlen(name);
>  	if (namelen < strlen("_device_table"))
>  		return;
> -- 
> 2.7.4