linux-kernel - Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c4f645219bb69f31777367d5edc0830c32467db.camel@perches.com>
Date:   Sun, 30 Sep 2018 11:35:01 -0700
From:   Joe Perches <joe@...ches.com>
To:     Rick Veens <rickveens92@...il.com>, gregkh@...uxfoundation.org,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtlwifi: Removed unused define and code
 efuse_re_pg* from wifi.h

On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
> The following:
>  bool efuse_re_pg_sec1flag;
>  u8 efuse_re_pg_data[8];
> are not referenced anywhere in the rtlwifi code.
> 
> Signed-off-by: Rick Veens <rickveens92@...il.com>
> ---
>  drivers/staging/rtlwifi/wifi.h | 4 ----

Presumably the equivalent uses in
	drivers/net/wireless/realtek/rtlwifi/wifi.h
should be removed as well.

> diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h
[]
> @@ -1840,10 +1840,6 @@ struct rtl_efuse {
>  	u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
>  	u16 efuse_usedbytes;
>  	u8 efuse_usedpercentage;
> -#ifdef EFUSE_REPG_WORKAROUND
> -	bool efuse_re_pg_sec1flag;
> -	u8 efuse_re_pg_data[8];
> -#endif
>  
>  	u8 autoload_failflag;
>  	u8 autoload_status;