linux-kernel - Re: [PATCH v8 RESEND 4/4] kdump/vmcore: support encrypted old memory with SME enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Sep 2018 12:22:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lianbo Jiang <lijiang@...hat.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        kexec@...ts.infradead.org, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, akpm@...ux-foundation.org,
        dan.j.williams@...el.com, thomas.lendacky@....com,
        bhelgaas@...gle.com, baiyaowei@...s.chinamobile.com, tiwai@...e.de,
        bp@...e.de, brijesh.singh@....com, dyoung@...hat.com,
        bhe@...hat.com, jroedel@...e.de
Subject: Re: [PATCH v8 RESEND 4/4] kdump/vmcore: support encrypted old memory
 with SME enabled

Hi Lianbo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sof-driver-fuweitax/master]
[also build test ERROR on v4.19-rc5 next-20180928]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lianbo-Jiang/Support-kdump-for-AMD-secure-memory-encryption-SME/20180930-112044
base:   https://github.com/fuweitax/linux master
config: x86_64-randconfig-x005-201839 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> arch/x86//kernel/crash_dump_64.c:93:9: error: redefinition of 'copy_oldmem_page_encrypted'
    ssize_t copy_oldmem_page_encrypted(unsigned long pfn, char *buf, size_t csize,
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/x86//kernel/crash_dump_64.c:10:0:
   include/linux/crash_dump.h:34:9: note: previous definition of 'copy_oldmem_page_encrypted' was here
    ssize_t copy_oldmem_page_encrypted(unsigned long pfn, char *buf, size_t csize,
            ^~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/copy_oldmem_page_encrypted +93 arch/x86//kernel/crash_dump_64.c

    78	
    79	/**
    80	 * copy_oldmem_page_encrypted - copy one page from "old memory encrypted"
    81	 * @pfn: page frame number to be copied
    82	 * @buf: target memory address for the copy; this can be in kernel address
    83	 *	space or user address space (see @userbuf)
    84	 * @csize: number of bytes to copy
    85	 * @offset: offset in bytes into the page (based on pfn) to begin the copy
    86	 * @userbuf: if set, @buf is in user address space, use copy_to_user(),
    87	 *	otherwise @buf is in kernel address space, use memcpy().
    88	 *
    89	 * Copy a page from "old memory encrypted". For this page, there is no pte
    90	 * mapped in the current kernel. We stitch up a pte, similar to
    91	 * kmap_atomic.
    92	 */
  > 93	ssize_t copy_oldmem_page_encrypted(unsigned long pfn, char *buf, size_t csize,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28437 bytes)