linux-kernel - Re: [PATCH V7 3/8] clocksource: add C-SKY SMP timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Oct 2018 08:02:08 +0800
From:   Guo Ren <ren_guo@...ky.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com,
        robh+dt@...nel.org, mark.rutland@....com, anurup.m@...wei.com,
        Jonathan.Cameron@...wei.com, will.deacon@....com,
        zhangshaokun@...ilicon.com, jhogan@...nel.org,
        paul.burton@...s.com, peterz@...radead.org, f.fainelli@...il.com,
        arnd@...db.de, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH V7 3/8] clocksource: add C-SKY SMP timer

On Sun, Sep 30, 2018 at 09:22:30PM +0200, Daniel Lezcano wrote:
> On 30/09/2018 18:18, Guo Ren wrote:
> > This timer is used by SMP system and use mfcr/mtcr instruction
> > to access the regs.
> > 
> > Changelog:
> >  - Remove #define CPUHP_AP_CSKY_TIMER_STARTING
> >  - Add CPUHP_AP_CSKY_TIMER_STARTING in cpuhotplug.h
> >  - Support csky mp timer alpha version.
> >  - Just use low-counter with 32bit width as clocksource.
> >  - Coding convention with upstream feed-back.
> > 
> > Signed-off-by: Guo Ren <ren_guo@...ky.com>
> > ---
> 
> 
> Guo,
> 
> what is the flow of your patches ?
> 
> You sent me a V8 with two patches and those timers which I commented.
> 
> And now there is this V7 with the patches previously sent as V8 without
> the comments take into account.
> 
> I'm a bit lost. Can you clarify ?
Opps ... I should send the "V9 C-SKY(csky) Linux Drivers". It's a wrong
patchset from "V6 C-SKY(csky) Linux Kernel Port".

The patchset didn't include your comment in V8:
 - Add COMIPLE_TEST in Kconfig
 - no cast is needed for "struct clock_event_device *ce = dev"
 - remove: extra space after (u64).

I'm sorry about it, I'll send "V9 C-SKY(csky) Linux Drivers". My fault.

Best Regards
 Guo Ren