lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20181001095214.pjp7cshbi3nxq6w5@mwanda>
Date:   Mon, 1 Oct 2018 12:52:14 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Andrey Abramov <st5pub@...dex.ru>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: media: replaced deprecated probe method

On Mon, Oct 01, 2018 at 12:42:29PM +0300, Andrey Abramov wrote:
> Replaced i2c_driver::probe with i2c_driver::probe_new,
> 	because documentation says that probe method is "soon to be deprecated".
> And fixed problems of the previous attempt.

I'm sorry to complain again...  Please, don't reference the "previous
attempt" in the commit message.  The previous attempt is gone so no one
will remember what you are talking about after tomorrow.  This is how
you resend a patch.

Change the subject to:

Subject: [PATCH v3] Staging: media: replace deprecated probe method

> 
> Signed-off-by: Andrey Abramov <st5pub@...dex.ru>
> ---
>  drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++---

Then right after the --- line put:

v3:  fix commit message

That part of the commit message will be removed when we apply the patch.

regards,
dan carpenter


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ