linux-kernel - Re: [PATCH] gpio: omap: get rid of the conditional PM runtime calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ-WOGqSThAPHw8LykriTnSEKZcZaL+iB5-jmaVKmN4bg@mail.gmail.com>
Date:   Mon, 1 Oct 2018 12:29:20 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     ext Tony Lindgren <tony@...mide.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: omap: get rid of the conditional PM runtime calls

On Fri, Sep 28, 2018 at 11:39 PM Grygorii Strashko
<grygorii.strashko@...com> wrote:

> OMAP GPIO driver is checking !BANK_USED() used condition before calling PM
> runtime API, because of PM runtime calls in
> omap2_gpio_prepare/resume_for_idle(). It's not required any more since
> "omap gpio add level idle, cpu_pm and drop runtime_irq_safe" series [1]
> from Tony Lindgren was accepted and PM runtime management was enabled in
> IRQ chip core by commit be45beb2df69 ("genirq: Add runtime power management
> support for IRQ chips") .
>
> As result safely drop !BANK_USED() checks from omap_gpio_request/free(),
> omap_gpio_irq_bus_lock/unlock() and enable PM runtime management for OMAP
> GPIO IRQ chip.
>
> [1] https://www.spinics.net/lists/arm-kernel/msg677583.html
> Tested-by: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Patch applied.

Yours,
Linus Walleij