linux-kernel - Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14ba57eb-0647-5dca-8f84-eaa27fd0af4a@axentia.se>
Date:   Mon, 1 Oct 2018 13:49:10 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Luca Ceresoli <lucaceresoli77@...il.com>, linux-i2c@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Luca Ceresoli <luca@...aceresoli.net>
Subject: Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the
 adapter

On 2018-09-26 10:35, Luca Ceresoli wrote:
> From: Luca Ceresoli <luca@...aceresoli.net>
> 
> struct i2c_client has a direct pointer to the adapter, no need to dig
> it out of the struct device tree.

Right, looks sane, but can you please also do the same thing for the
ltc4306 and mlxcpld drivers which have the same pattern?

Cheers,
Peter

> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
> ---
> 
> Sorry for the RESEND noise, but my provider and vger are not
> interacting (again). I'll solve the issue at its root ASAP, but in the
> meanwhile I'm sending from a different account.
> 
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index 24bd9275fde5..bfabf985e830 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -347,7 +347,7 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
>  static int pca954x_probe(struct i2c_client *client,
>  			 const struct i2c_device_id *id)
>  {
> -	struct i2c_adapter *adap = to_i2c_adapter(client->dev.parent);
> +	struct i2c_adapter *adap = client->adapter;
>  	struct pca954x_platform_data *pdata = dev_get_platdata(&client->dev);
>  	struct device *dev = &client->dev;
>  	struct device_node *np = dev->of_node;
>