linux-kernel - Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35cd9295-17fd-bb83-138d-0fe6c4323e07@linaro.org>
Date:   Mon, 1 Oct 2018 07:10:21 -0500
From:   Alex Elder <elder@...aro.org>
To:     Niklas Cassel <niklas.cassel@...aro.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>
Cc:     bjorn.andersson@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

On 10/01/2018 04:55 AM, Niklas Cassel wrote:
> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
> 
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>

Looks good to me.  If someone needs it, they know what it's for.

Reviewed-by: Alex Elder <elder@...aro.org>

> ---
>  drivers/soc/qcom/Kconfig | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 684cb51694d1..fcbf8a2e4080 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
>  	tristate
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on NET
> -	help
> -	  Helper library for handling QMI encoded messages.  QMI encoded
> -	  messages are used in communication between the majority of QRTR
> -	  clients and this helpers provide the common functionality needed for
> -	  doing this from a kernel driver.
>  
>  config QCOM_RMTFS_MEM
>  	tristate "Qualcomm Remote Filesystem memory driver"
>