linux-kernel - Re: [PATCH] KVM/VMX: Remve unused function is_external

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e49da77-933f-774f-0cad-9bbaaf1fdaf3@redhat.com>
Date:   Mon, 1 Oct 2018 16:00:37 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Tianyu Lan <Tianyu.Lan@...rosoft.com>
Cc:     "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM/VMX: Remve unused function is_external_interrupt().

On 28/09/2018 14:45, Tianyu Lan wrote:
> is_external_interrupt() is not used now and so remove it.
> 
> Signed-off-by: Lan Tianyu <Tianyu.Lan@...rosoft.com>
> ---
>  arch/x86/kvm/vmx.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 70e1f916bfc9..619307b3e6bb 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -1667,12 +1667,6 @@ static inline bool is_gp_fault(u32 intr_info)
>  	return is_exception_n(intr_info, GP_VECTOR);
>  }
>  
> -static inline bool is_external_interrupt(u32 intr_info)
> -{
> -	return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VALID_MASK))
> -		== (INTR_TYPE_EXT_INTR | INTR_INFO_VALID_MASK);
> -}
> -
>  static inline bool is_machine_check(u32 intr_info)
>  {
>  	return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VECTOR_MASK |
> 

Queued, thanks.

Paolo