linux-kernel - Re: [PATCH v9 0/3] powerpc: Detection and scheduler optimization for POWER9 bigcore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <994106db-7f79-7d22-0d4e-f458bd85bb64@intel.com>
Date:   Mon, 1 Oct 2018 07:05:11 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Neuling <mikey@...ling.org>,
        Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>,
        Akshay Adiga <akshay.adiga@...ux.vnet.ibm.com>,
        Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
        Oliver O'Halloran <oohall@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Murilo Opsfelder Araujo <muriloo@...ux.ibm.com>,
        Anton Blanchard <anton@...ba.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 0/3] powerpc: Detection and scheduler optimization for
 POWER9 bigcore

On 10/01/2018 06:16 AM, Gautham R. Shenoy wrote:
> 
> Patch 3: Creates a pair of sysfs attributes named
> 	  /sys/devices/system/cpu/cpuN/topology/smallcore_thread_siblings
> 	  and
> 	  /sys/devices/system/cpu/cpuN/topology/smallcore_thread_siblings_list
> 	  exposing the small-core siblings that share the L1 cache
> 	  to the userspace.

I really don't think you've justified the existence of a new user/kernel
interface here.  We already have information about threads share L1
caches in here:

	/sys/devices/system/cpu/cpu0/cache/index0/shared_cpu_list

The only question would be if anything would break because it assumes
that all SMT siblings share all caches.  But, it breaks if your new
interface is there or not; it's old software that we care about.