linux-kernel - Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd2js3QCJYjPDea5xapYLiOObSUF7_Q2hjG8RS=QYyPaQ@mail.gmail.com>
Date:   Mon, 1 Oct 2018 21:13:09 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Jean Delvare <jdelvare@...e.de>, kramasub@...eaurora.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Eddie James <eajames@...ux.vnet.ibm.com>,
        James Hogan <jhogan@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        "Krogerus, Heikki" <heikki.krogerus@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs

On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>
> ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
> same controller, make it possible to select the STB driver and update
> the Kconfig and help text a bit.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Changes in v2:
>
> - Make COMPILE_TEST last, as per Geert's recommendation
>
>  drivers/i2c/busses/Kconfig | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 451d4ae50e66..56ccb1ea7da5 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -432,12 +432,13 @@ config I2C_BCM_KONA
>           If you do not need KONA I2C interface, say N.
>
>  config I2C_BRCMSTB
> -       tristate "BRCM Settop I2C controller"
> -       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> +       tristate "BRCM Settop/DSL I2C controller"
> +       depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> +                  COMPILE_TEST

I would rather split this to two 'depends' entries, though it's
cosmetic and up to you.

>         default y
>         help
>           If you say yes to this option, support will be included for the
> -         I2C interface on the Broadcom Settop SoCs.
> +         I2C interface on the Broadcom Settop/DSL SoCs.
>
>           If you do not need I2C interface, say N.
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko