linux-kernel - Re: [PATCH] usbip: fix vhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91b66186-9e1c-6fc4-1e51-0f346725c4cf@kernel.org>
Date:   Mon, 1 Oct 2018 13:11:55 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Maciej Żenczykowski <zenczykowski@...il.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Dieter <jdieter@...il.com>,
        Valentina Manea <valentina.manea.m@...il.com>,
        linux-usb@...r.kernel.org, jdieter@...il.com,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] usbip: fix vhci_hcd controller counting

On 09/20/2018 02:29 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> Without this usbip fails on a machine with devices
> that lexicographically come after vhci_hcd.
> 
> ie.
>   $ ls -l /sys/devices/platform
>   ...
>   drwxr-xr-x. 4 root root    0 Sep 19 16:21 serial8250
>   -rw-r--r--. 1 root root 4096 Sep 19 23:50 uevent
>   drwxr-xr-x. 6 root root    0 Sep 20 13:15 vhci_hcd.0
>   drwxr-xr-x. 4 root root    0 Sep 19 16:22 w83627hf.656
> 
> Because it detects 'w83627hf.656' as another vhci_hcd controller,
> and then fails to be able to talk to it.
> 
> Note: this doesn't actually fix usbip's support for multiple
> controllers... that's still broken for other reasons
> ("vhci_hcd.0" is hardcoded in a string macro), but is enough to
> actually make it work on the above machine.
> 
> See also:
>   https://bugzilla.redhat.com/show_bug.cgi?id=1631148
> 
> Cc: Jonathan Dieter <jdieter@...il.com>
> Cc: Valentina Manea <valentina.manea.m@...il.com>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Maciej Żenczykowski <zenczykowski@...il.com>
> ---
>  tools/usb/usbip/libsrc/vhci_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/libsrc/vhci_driver.c b/tools/usb/usbip/libsrc/vhci_driver.c
> index 4204359c9fee..8159fd98680b 100644
> --- a/tools/usb/usbip/libsrc/vhci_driver.c
> +++ b/tools/usb/usbip/libsrc/vhci_driver.c
> @@ -150,7 +150,7 @@ static int get_nports(struct udev_device *hc_device)
>  
>  static int vhci_hcd_filter(const struct dirent *dirent)
>  {
> -	return strcmp(dirent->d_name, "vhci_hcd") >= 0;
> +	return !strncmp(dirent->d_name, "vhci_hcd.", 9);
>  }
>  
>  static int get_ncontrollers(void)
> 

Thanks for the patch. Looks good to me.

Greg! Can you please pick this up.

Acked-by: Shuah Khan (Samsung OSG) <shuah@...nel.org>


thanks,
-- Shuah





thanks,
-- Shuah