linux-kernel - Re: [PATCH] qxl: fix null-pointer crash during suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJAFBLBhAjEtoCegy7QzG65PoxM-DZA2xki9SwfrZ6af=0fvUQ@mail.gmail.com>
Date:   Mon, 1 Oct 2018 13:13:59 -0700
From:   Fubo Chen <fubo.chen@...il.com>
To:     peter@...ensteyn.nl
Cc:     airlied@...hat.com, kraxel@...hat.com,
        alan.christopher.jenkins@...il.com,
        virtualization@...ts.linux-foundation.org,
        dri-devel@...ts.freedesktop.org,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qxl: fix null-pointer crash during suspend

On Tue, Sep 4, 2018 at 2:10 PM Peter Wu <peter@...ensteyn.nl> wrote:
>
> "crtc->helper_private" is not initialized by the QXL driver and thus the
> "crtc_funcs->disable" call would crash (resulting in suspend failure).
> Fix this by converting the suspend/resume functions to use the
> drm_mode_config_helper_* helpers.
>
> Tested system sleep with QEMU 3.0 using "echo mem > /sys/power/state".
> During suspend the following message is visible from QEMU:
>
>     spice/server/display-channel.c:2425:display_channel_validate_surface: canvas address is 0x7fd05da68308 for 0 (and is NULL)
>     spice/server/display-channel.c:2426:display_channel_validate_surface: failed on 0
>
> This seems to be triggered by QXL_IO_NOTIFY_CMD after
> QXL_IO_DESTROY_PRIMARY_ASYNC, but aside from the warning things still
> seem to work (tested with both the GTK and -spice options).
>
> Signed-off-by: Peter Wu <peter@...ensteyn.nl>

Is this a new issue or something that was introduced a long time ago?
In the latter case, please consider adding a "Cc:
<stable@...r.kernel.org>" tag to this patch.

Thanks,

Fubo.