linux-kernel - Re: 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181001204022.GE69414@sasha-vm>
Date:   Mon, 1 Oct 2018 20:40:24 +0000
From:   Sasha Levin <Alexander.Levin@...rosoft.com>
To:     Daniel Wang <wonderfly@...gle.com>
CC:     "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "byungchul.park@....com" <byungchul.park@....com>,
        "dave.hansen@...el.com" <dave.hansen@...el.com>,
        "hannes@...xchg.org" <hannes@...xchg.org>,
        "jack@...e.cz" <jack@...e.cz>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "mhocko@...nel.org" <mhocko@...nel.org>,
        "pavel@....cz" <pavel@....cz>,
        "penguin-kernel@...ove.sakura.ne.jp" 
        <penguin-kernel@...ove.sakura.ne.jp>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "tj@...nel.org" <tj@...nel.org>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        Peter Feiner <pfeiner@...gle.com>
Subject: Re: 4.14 backport request for dbdda842fe96f: "printk: Add console
 owner and waiter logic to load balance console writes"

On Mon, Oct 01, 2018 at 01:37:30PM -0700, Daniel Wang wrote:
>On Mon, Oct 1, 2018 at 12:23 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>>
>> > Serial console logs leading up to the deadlock. As can be seen the stack trace
>> > was incomplete because the printing path hit a timeout.
>>
>> I'm fine with having this backported.
>
>Thanks. I can send the cherrypicks your way. Do you recommend that I
>include the three follow-up fixes though?
>
>c14376de3a1b printk: Wake klogd when passing console_lock owner
>fd5f7cde1b85 printk: Never set console_may_schedule in console_trylock()
>c162d5b4338d printk: Hide console waiter logic into helpers
>dbdda842fe96 printk: Add console owner and waiter logic to load
>balance console writes

Maybe it'll also make sense to make the reproducer into a test that can
go under tools/testing/ and we can backport that as well? It'll be
helpful to have a way to make sure things are sane.

--
Thanks,
Sasha