linux-kernel - Re: [PATCH] regulator: fixed: Default enable high on DT regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLU-fWHQetRFeghbe+XT504YXHFXLVi6CbBsXisNSdQ-OA@mail.gmail.com>
Date:   Mon, 1 Oct 2018 14:56:10 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Leonard Crestez <leonard.crestez@....com>,
        Fabio Estevam <festevam@...il.com>,
        Anders Roxell <anders.roxell@...aro.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators

On Mon, Oct 1, 2018 at 1:43 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> commit efdfeb079cc3
> ("regulator: fixed: Convert to use GPIO descriptor only")
> switched to use gpiod_get() to look up the regulator from the
> gpiolib core whether that is device tree or boardfile.
>
> This meant that we activate the code in
> a603a2b8d86e ("gpio: of: Add special quirk to parse regulator flags")
> which means the descriptors coming from the device tree already
> have the right inversion and open drain semantics set up from
> the gpiolib core.
>
> As the fixed regulator was inspected again we got the
> inverted inversion and things broke.
>
> Fix it by ignoring the config in the device tree for now: the
> later patches in the series will push all inversion handling
> over to the gpiolib core and set it up properly in the
> boardfiles for legacy devices, but I did not finish that
> for this kernel cycle.
>
> Fixes: commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor only")
> Reported-by: Leonard Crestez <leonard.crestez@....com>
> Reported-by: Fabio Estevam <festevam@...il.com>
> Reported-by: John Stultz <john.stultz@...aro.org>
> Reported-by: Anders Roxell <anders.roxell@...aro.org>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

This seems to solve it!

Tested-by: John Stultz <john.stultz@...aro.org>