linux-kernel - Re: [PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002145116.GE3889@infradead.org>
Date:   Tue, 2 Oct 2018 07:51:16 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Zong Li <zongbox@...il.com>
Cc:     palmer@...ive.com, aou@...s.berkeley.edu, hch@...radead.org,
        zong@...estech.com, linux-riscv@...ts.infradead.org,
        Vincent Chen <vincentc@...estech.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of
 phys_addr_t in ioremap

On Tue, Oct 02, 2018 at 04:52:31PM +0800, Zong Li wrote:
> From: Vincent Chen <vincentc@...estech.com>
> 
> For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero
> after AND with PAGE_MASK because the data type of PAGE_MASK is
> unsigned long. To fix this problem, the page alignment is done by
> subtracting the page offset instead of AND with PAGE_MASK.
> 
> Signed-off-by: Vincent Chen <vincentc@...estech.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>

(and I'm pretty sure I reviewed this before..)