linux-kernel - Re: [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=VArNPwqxdjCo772V7ZmBQuirHSUpaeVvziiKgdUc-meA@mail.gmail.com>
Date:   Tue, 2 Oct 2018 08:15:10 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     ryandcase@...omium.org
Cc:     Mark Brown <broonie@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Trent Piepho <tpiepho@...inj.com>, boris.brezillon@...tlin.com,
        Girish Mahadevan <girishm@...eaurora.org>,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

Hi,
On Mon, Oct 1, 2018 at 6:32 PM Ryan Case <ryandcase@...omium.org> wrote:
>
> From: Girish Mahadevan <girishm@...eaurora.org>
>
> Bindings for Qualcomm Quad SPI used on SoCs such as sdm845.
>
> Signed-off-by: Girish Mahadevan <girishm@...eaurora.org>
> Signed-off-by: Ryan Case <ryandcase@...omium.org>
> ---
>
> Changes in v5:
> - None
>
> Changes in v4:
> - Changed qspi@ to spi@ and device@ to flash@ to match Rob's review

Rob said that with those changes you could add his reviewed by [1], so
this patch should have carried:

Reviewed-by: Rob Herring <robh@...nel.org>

I'd also say that usually when changes are minor you can make a
judgement call and carry previous reviews.  If there's any question
about whether previous reviews can be carried you can mention it
somewhere in your changelog.  In this particular case I would have
called the changes minor / non-controversial so I would have kept
Stephen and my reviews when posting the new patch.  In any case
Stephen has already re-provided his review and you can feel free to
add:

Reviewed-by: Douglas Anderson <dianders@...omium.org>


[1] https://lkml.kernel.org/r/20180927204624.GA7072@bogus