linux-kernel - Re: [PATCHv3 6/6] mm/gup: Cache dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bb265e9-bc23-799a-ad01-30edbc762996@intel.com>
Date:   Tue, 2 Oct 2018 08:49:39 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Keith Busch <keith.busch@...el.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCHv3 6/6] mm/gup: Cache dev_pagemap while pinning pages

On 10/02/2018 04:26 AM, Kirill A. Shutemov wrote:
>> +	page = follow_page_mask(vma, address, foll_flags, &ctx);
>> +	if (ctx.pgmap)
>> +		put_dev_pagemap(ctx.pgmap);
>> +	return page;
>>  }
> Do we still want to keep the function as inline? I don't think so.
> Let's move it into mm/gup.c and make struct follow_page_context private to
> the file.

Yeah, and let's have a put_follow_page_context() that does the
put_dev_pagemap() rather than spreading that if() to each call site.