linux-kernel - Re: [PATCH] ARM: OMAP1: ams-delta: Fix impossible .irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002174745.GG3461@darkstar.musicnaut.iki.fi>
Date:   Tue, 2 Oct 2018 20:47:45 +0300
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Janusz Krzysztofik <jmkrzyszt@...il.com>
Cc:     Tony Lindgren <tony@...mide.com>,
        linux-arm-kernel@...ts.infradead.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix impossible .irq < 0

Hi,

On Tue, Oct 02, 2018 at 11:45:29AM +0200, Janusz Krzysztofik wrote:
> Since the very beginning, unsigned int .irq member of struct
> plat_serial8250_port introduced by commit eff443df679e ("OMAP1:
> AMS_DELTA: add modem support") was statically initialized to a negative
> value -EINVAL.  Moreover, commit 0812db943748 ("ARM: OMAP1: ams-delta:
> assign MODEM IRQ from GPIO descriptor") has introduced some new code
> which checks for that member carrying a negative value which is
> impossible.
> 
> Use IRQ_NOTCONNECTED instead of -EINVAL. Also, drop the valueless check
> and let the modem device be registered regardless of .irq value, and
> the value handled by "serial8250" driver.
> 
> Fixes: 0812db943748 ("ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@...il.com>

Acked-by: Aaro Koskinen <aaro.koskinen@....fi>

A.