linux-kernel - Re: [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Oct 2018 23:22:00 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Joachim Eastwood <manabian@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        rdunlap@...radead.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable

wt., 2 paź 2018 o 23:10 Arnd Bergmann <arnd@...db.de> napisał(a):
>
> drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':
> drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/nvmem/lpc18xx_eeprom.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
> index b42dbaddb419..66cff1e2147a 100644
> --- a/drivers/nvmem/lpc18xx_eeprom.c
> +++ b/drivers/nvmem/lpc18xx_eeprom.c
> @@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
>  static int lpc18xx_eeprom_remove(struct platform_device *pdev)
>  {
>         struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
> -       int ret;
>
>         clk_disable_unprepare(eeprom->clk);
>
> --
> 2.18.0
>

Hi Arnd,

I had already sent a fix for that with you in Cc:
https://lkml.org/lkml/2018/10/2/439

Best regards,
Bartosz