linux-kernel - Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b3bc158-b836-7b44-ef09-7c124f479c58@rockbox.org>
Date:   Tue, 2 Oct 2018 23:26:35 +0200
From:   Thomas Martitz <kugel@...kbox.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Daniel Drake <drake@...lessm.com>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Linux Upstreaming Team <linux@...lessm.com>,
        nouveau@...ts.freedesktop.org, Linux PM <linux-pm@...r.kernel.org>,
        Peter Wu <peter@...ensteyn.nl>, kherbst@...hat.com,
        andy.shevchenko@...ux.intel.com,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Keith Busch <keith.busch@...el.com>,
        Jon Derrick <jonathan.derrick@...el.com>,
        David Miller <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        netdev <netdev@...r.kernel.org>, nic_swsd@...ltek.com,
        rchang@...vell.com, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume

Am 02.10.18 um 22:03 schrieb Bjorn Helgaas:
> Hi Thomas,
> 
> On Mon, Oct 01, 2018 at 04:25:06PM +0200, Thomas Martitz wrote:
>> Am 01.10.18 um 06:57 schrieb Daniel Drake:
>>> On Sun, Sep 30, 2018 at 5:07 AM Thomas Martitz <kugel@...kbox.org> wrote:
>>>> The latest iteration does not work on my HP system. The GPU fails to
>>>> power up just like the unpatched kernel.
>>>
>>> That's weird, I would not expect a behaviour change in the latest
>>> patch. pci_restore_config_dword() has some debug messages, could you
>>> please make them visible and show logs again?
>>> Also remind us of the PCI device address of the parent bridge (lspci -vt)
>>
>> I'll follow up with more the requested information on bugzilla
>> (Link: https://bugzilla.kernel.org/show_bug.cgi?id=201069).
>>
>> On a quick re-check, it seems to depend on if I used the eGPU before
>> the initial suspend. If I run glxgears (with DRI_PRIME=1) before suspend it
>> seems fine.
> 
> Does the patch ([1]) make things *worse* compared to v4.19-rc5?
> 

No, certainly not. It does look like a different issue since resuming now
works at least if I used the eGPU in some way before suspend 
(DRI_PRIME=1 glxgears seems to be enough, I assume glxinfo would work as 
well).

Without the patch resuming the eGPU does not work whatsoever.

Please ship the patch. I'll hopefully sort this other issue out.

Best regards.