linux-kernel - Re: [PATCHv5 3/7] tty: Hold tty_ldisc_lock() during tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1538515983.4348.93.camel@arista.com>
Date:   Tue, 02 Oct 2018 22:33:03 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     "Guilherme G. Piccoli" <gpiccoli@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv5 3/7] tty: Hold tty_ldisc_lock() during tty_reopen()

Hi Guilherme,

On Mon, 2018-10-01 at 16:01 -0300, Guilherme G. Piccoli wrote:
> On 01/10/2018 15:32, Guilherme G. Piccoli wrote:
> > Hi Dmitry, thanks for the patch. It's very promising, we have some
> > reports of this issue and I'm building a kernel with this patch in
> > order the reporter can test it. But based in the previous feedback,
> > this seems to be very mature now and ready to get merged, right?

Well, v5 passes 0day, so all previous reports are fixed.
But there is a new one about reboot on parisc platform which takes ~3
mins after the patch with ldisc locked on tty_reopen().

I believe it's related to holding read side for too long..
So, the patches still need another fix, heh.

Unfortunately, I was a bit busy with other bugs hitting more in Arista.

> > I'd like to ask you if you did respin the patch with Greg's
> > suggestion
> > for the tag - I couldn't find it in LKML heheh
> > 
> > Oh, if you can CC me in future spins of this patch (in case there
> > any),
> > I'd really be glad.

Sure, will enlarge Cc list ;)

> > 
> > Thank in advance,
> > 
> > 
> > Guilherme
> > 
> 
> 
> Sorry, forgot to CC linux-kernel...

-- 
Thanks,
             Dmitry