linux-kernel - Re: linux-next: build warning after merge of the regulator tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002064317.GD9389@localhost.localdomain>
Date:   Tue, 2 Oct 2018 09:43:17 +0300
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the regulator tree

Hello Stephen, Mark & All,

On Tue, Oct 02, 2018 at 04:25:51PM +1000, Stephen Rothwell wrote:
> On Tue, 2 Oct 2018 09:16:44 +0300 Matti Vaittinen <matti.vaittinen@...rohmeurope.com> wrote:
> >
> > On Tue, Oct 02, 2018 at 01:07:48PM +1000, Stephen Rothwell wrote:
> > > After merging the regulator tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > drivers/mfd/rohm-bd718x7.c: In function 'bd718xx_i2c_probe':
> > > drivers/mfd/rohm-bd718x7.c:101:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > >   bd718xx->chip_type = (unsigned int)  
> > 
> > I am pretty sure the last patch version corrected this to
> > +       bd71837->chip_type = (unsigned int)(uintptr_t)
> > +                               of_device_get_match_data(&i2c->dev);
> > 
> > is it possible one of the earlier versions has accidentally been
> > applied? Should I create patch on top of the last regulator tree or what
> > is the simplest way fix this?
> 
> Sorry, this came from commit
> 
>   dd2be639f4a9 ("regulator/mfd: bd718xx: rename bd71837/bd71847 common instances")
> 
> which is later than the commit I noted.  In this later commit, this happens:
> 
> -	bd71837->chip_irq = i2c->irq;
> -	bd71837->chip_type = (unsigned int)(uintptr_t)
> +	bd718xx->chip_irq = i2c->irq;
> +	bd718xx->chip_type = (unsigned int)
>  				of_device_get_match_data(&i2c->dev);

Right. So looks like I am still the guilty one then. I've overwritten
the fix in this rename patch which followed the corrected initial
support patch. I guess sending incremental patch with fix to regulator
tree is correct way to go, right? I'll prepare one against Mark's branch
"origin/topic/bd718xx". Mark, please let me know if you want me to send
it or if I should do it on top of some other branch.

Br,
	Matti Vaittinen