lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Oct 2018 09:35:02 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: taoren@...com Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>, mine260309@...il.com, OpenBMC Maillist <openbmc@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-aspeed@...ts.ozlabs.org Subject: Re: [PATCH] clocksource/drivers/fttmr010: fix invalid interrupt register access Hi Tao, thanks for your patch! On Tue, Oct 2, 2018 at 6:14 AM Tao Ren <taoren@...com> wrote: > - if (fttmr010->count_down) > + if (fttmr010->count_down) { > writel(~0, fttmr010->base + TIMER1_LOAD); This struct member "count_down" is a bit badly named now don't you think? The patch is fine semantically, but please rename this member "is_aspeed" or something like that and update the code everywhere, then insert a comments like /* The Aspeed variant counts downward */ /* The Aspeed variant does not have a match interrupt */ in the code snippets so we see what is going on. Yours, Linus Walleij
Powered by blists - more mailing lists