linux-kernel - Re: [PATCH] pinctrl: msm: Actually use function 0 for gpio selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb-VmT4SXWWf_Gj=4U77T1x0+ggRW2-1e0De4eQdrWiDw@mail.gmail.com>
Date:   Tue, 2 Oct 2018 10:49:53 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Doug Anderson <dianders@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Niklas Cassel <niklas.cassel@...aro.org>
Subject: Re: [PATCH] pinctrl: msm: Actually use function 0 for gpio selection

On Mon, Oct 1, 2018 at 11:49 PM Stephen Boyd <swboyd@...omium.org> wrote:

> This code needs to select function #0, which is the first int in the
> array of functions, not the number 0 which may or may not be the
> function for "GPIO mode" per the enum mapping. We were getting lucky on
> SDM845, where this was tested, because the function 0 matched the enum
> value for "GPIO mode". On other platforms, e.g. MSM8996, the gpio enum
> value is the last one in the list so this code doesn't work and we see a
> warning at boot. Fix it by grabbing the first element out of the array
> of functions.
>
> Cc: Doug Anderson <dianders@...omium.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Niklas Cassel <niklas.cassel@...aro.org>
> Reported-by: Niklas Cassel <niklas.cassel@...aro.org>
> Fixes: 1de7ddb3a15c ("pinctrl: msm: Mux out gpio function with gpio_request()")
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Patch applied with all the tags.

Yours,
Linus Walleij