linux-kernel - Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Oct 2018 13:27:53 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Jean Delvare <jdelvare@...e.de>, kramasub@...eaurora.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Eddie James <eajames@...ux.vnet.ibm.com>,
        James Hogan <jhogan@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        "Krogerus, Heikki" <heikki.krogerus@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs

On Tue, Oct 2, 2018 at 1:22 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Mon, Oct 1, 2018 at 8:13 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@...il.com> wrote:
> > >
> > >  config I2C_BRCMSTB
> > > -       tristate "BRCM Settop I2C controller"
> > > -       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > > +       tristate "BRCM Settop/DSL I2C controller"
> > > +       depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> > > +                  COMPILE_TEST
> >
> > I would rather split this to two 'depends' entries, though it's
> > cosmetic and up to you.
>
> You can only split 'depends on A && B' into multiple lines, not
> 'depends on A || B'.

Indeed. What I was thinking of?

-- 
With Best Regards,
Andy Shevchenko