linux-kernel - Re: [PATCH v3 1/2] drivers: base: cacheinfo: Do not populate sysfs for unknown cache types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002104946.GA1086@e107155-lin>
Date:   Tue, 2 Oct 2018 11:49:46 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     gregkh@...uxfoundation.org, rjw@...ysocki.net,
        linux-acpi@...r.kernel.org, jeremy.linton@....com,
        linux-kernel@...r.kernel.org, vkilari@...eaurora.org
Subject: Re: [PATCH v3 1/2] drivers: base: cacheinfo: Do not populate sysfs
 for unknown cache types

On Thu, Sep 27, 2018 at 08:57:56PM -0600, Jeffrey Hugo wrote:
> If a cache has an unknown type because neither the hardware nor the
> firmware told us, an entry in the sysfs tree will be made, but the type
> file will not be present.  lscpu depends on the type file being present
> for every entry, and will error out without printing system information
> if lscpu cannot open the type file.
> 
> Presenting information about a cache without indicating its type is not
> useful, therefore if we hit a cache with an unknown type, stop populating
> sysfs so that userspace has the maximum amount of useful information.
> 
> This addresses the following lscpu error, which prevents any output.
> lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such
> file or directory
> 
> Suggested-by: Sudeep Holla <sudeep.holla@....com>
> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> Reviewed-by: Jeremy Linton <jeremy.linton@....com>

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

--
Regards,
Sudeep