linux-kernel - Re: [PATCH v2 3/5] x86: pgtable: Drop pXd_none() checks from pXd_free_pYd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1810021326300.32062@nanos.tec.linutronix.de>
Date:   Tue, 2 Oct 2018 13:30:57 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Will Deacon <will.deacon@....com>
cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        cpandya@...eaurora.org, toshi.kani@....com, mhocko@...e.com,
        akpm@...ux-foundation.org, sean.j.christopherson@...el.com
Subject: Re: [PATCH v2 3/5] x86: pgtable: Drop pXd_none() checks from
 pXd_free_pYd_table()

On Tue, 2 Oct 2018, Will Deacon wrote:

Subject prefix wants to be 'x86/pgtable:' please

> Now that the core code checks this for us, we don't need to do it in the
> backend.

According to Documentation changelogs want to be written in imperative
mood.

  The core code has a check for pXd_none() already. Remove it in the
  architecture implementation.

Or something like that.

> Cc: Chintan Pandya <cpandya@...eaurora.org>
> Cc: Toshi Kani <toshi.kani@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Reviewed-by: Toshi Kani <toshi.kani@....com>
> Signed-off-by: Will Deacon <will.deacon@....com>

Other than the nits above:

  Acked-by: Thomas Gleixner <tglx@...utronix.de>