linux-kernel - Re: [PATCH 4.14 114/165] x86/vdso: Fix vDSO build if a retpoline is emitted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181002114614.GA2581@kroah.com>
Date:   Tue, 2 Oct 2018 04:46:14 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nikola Ciprich <nikola.ciprich@...uxbox.cz>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Matt Rickard <matt@...trans.com.au>,
        Borislav Petkov <bp@...en8.de>,
        Jason Vas Dias <jason.vas.dias@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 4.14 114/165] x86/vdso: Fix vDSO build if a retpoline is
 emitted

On Tue, Oct 02, 2018 at 10:06:55AM +0200, Nikola Ciprich wrote:
> Hi Greg and others,
> 
> sorry for reporting this so late, but still...
> 
> this breaks build on older compilers, since it requires
> -mindirect-branch=thunk-inline -mindirect-branch-register even though
> retpoline support is disabled in kernel config.. is this expected?

What exact "older compilers" break here?

And does the same breakage happen in 4.18.6 or 4.19-rc?

thanks,

greg k-h