linux-kernel - Re: [PATCH] bus: fsl-mc: explicitly define the fsl_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <868a0ddc-4b80-c866-a91e-7d6bc3af34da@nxp.com>
Date:   Tue, 2 Oct 2018 13:12:44 +0000
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Leo Li <leoyang.li@....com>
CC:     "stuyoder@...il.com" <stuyoder@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] bus: fsl-mc: explicitly define the fsl_mc_command
 endianness


On 02.10.2018 15:16, Ioana Ciornei wrote:
> Both the header and the command parameters of the fsl_mc_command are
> 64-bit little-endian words. Use the appropriate type to explicitly
> specify their endianness.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Reviewed-By: Laurentiu Tudor <laurentiu.tudor@....com>

---
Best Regards, Laurentiu

> ---
>   include/linux/fsl/mc.h | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
> index f27cb14..96c54bb 100644
> --- a/include/linux/fsl/mc.h
> +++ b/include/linux/fsl/mc.h
> @@ -210,8 +210,8 @@ struct mc_cmd_header {
>   };
>   
>   struct fsl_mc_command {
> -	u64 header;
> -	u64 params[MC_CMD_NUM_OF_PARAMS];
> +	__le64 header;
> +	__le64 params[MC_CMD_NUM_OF_PARAMS];
>   };
>   
>   enum mc_cmd_status {
> @@ -238,11 +238,11 @@ enum mc_cmd_status {
>   /* Command completion flag */
>   #define MC_CMD_FLAG_INTR_DIS	0x01
>   
> -static inline u64 mc_encode_cmd_header(u16 cmd_id,
> -				       u32 cmd_flags,
> -				       u16 token)
> +static inline __le64 mc_encode_cmd_header(u16 cmd_id,
> +					  u32 cmd_flags,
> +					  u16 token)
>   {
> -	u64 header = 0;
> +	__le64 header = 0;
>   	struct mc_cmd_header *hdr = (struct mc_cmd_header *)&header;
>   
>   	hdr->cmd_id = cpu_to_le16(cmd_id);
>