linux-kernel - Re: [RFC PATCH v3 4/7] powerpc: regain entire stack space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a539614-abb6-d468-ccba-2e3c1fb8b680@c-s.fr>
Date:   Wed, 3 Oct 2018 07:52:59 +0200
From:   Christophe LEROY <christophe.leroy@....fr>
To:     Nicholas Piggin <npiggin@...il.com>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        aneesh.kumar@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RFC PATCH v3 4/7] powerpc: regain entire stack space



Le 03/10/2018 à 07:34, Nicholas Piggin a écrit :
> On Mon,  1 Oct 2018 12:30:25 +0000 (UTC)
> Christophe Leroy <christophe.leroy@....fr> wrote:
> 
>> thread_info is not anymore in the stack, so the entire stack
>> can now be used.
> 
> Nice.
> 
>>
>> In the meantime, all pointers to the stacks are not anymore
>> pointers to thread_info so this patch changes them to void*
> 
> Wasn't this previously effectively already the case with patch
> 3/7? You had thread_info sized space left there, but it was not
> used or initialized right? Does it make sense to move this part
> of it to the previous patch?

Not really.

In 3/7 I changed the prototypes of two functions that really used the 
pointer as a task pointer only.

Here it change things that before 4/7 were really used as both stack 
pointers and thread_info pointers.

Christophe

> 
> Thanks,
> Nick
>