linux-kernel - Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bm8bjtjv.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 03 Oct 2018 11:58:12 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Luciano Coelho <luciano.coelho@...el.com>
Cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-kernel@...r.kernel.org,
        Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

Luciano Coelho <luciano.coelho@...el.com> writes:

>> +#if IS_ENABLED(CONFIG_BT_INTEL)
>> +		if (firmware_unlock_func) {
>> +			firmware_unlock_func();
>> +			symbol_put(btintel_firmware_lock);
>> +			firmware_lock_func = NULL;
>> +			symbol_put(btintel_firmware_unlock);
>> +			firmware_unlock_func = NULL;
>> +		}
>> +#endif
>> +	}
>>  	else
>>  		ret = iwl_pcie_load_given_ucode(trans, fw);
>>  
>
> I'm not sure I like adding this BT-specific stuff here, especially not
> without a detailed explanation.

This looks like an ugly hack and the commit log tells nothing. This
really needs strong justifications to even consider doing something like
this.

-- 
Kalle Valo