linux-kernel - Re: [PATCH] regulator: fixed: Default enable high on DT regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181003121002.GA7132@sirena.org.uk>
Date:   Wed, 3 Oct 2018 13:10:02 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Leonard Crestez <leonard.crestez@....com>
Cc:     "festevam@...il.com" <festevam@...il.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        Andy Duan <fugang.duan@....com>,
        "anders.roxell@...aro.org" <anders.roxell@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators

On Tue, Oct 02, 2018 at 01:42:38PM +0000, Leonard Crestez wrote:

> This turns the phy off and on again instead of leaving it up from uboot
> and it doesn't work for some reason. However looking at
> reg_fixed_voltage_probe introducing an edge seems to be intentional for
> regulators which are not marked with "enabled-at-boot". Right?

No, that's definitely not desired.  We don't want to change the state of
the regulator at all if we can avoid it unless the user explicitly asked
for it.

> It's possible that you exposed an imx board-specific bug: maybe power
> cycling the phy after uboot needs some missing fixup?

It'd probably also be good to sort this out though.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)