[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=XnkGA-3LOxJUVoYbSQ5QwVk21_N=pVLhfQySCG30heAw@mail.gmail.com>
Date: Wed, 3 Oct 2018 10:45:02 -0700
From: Doug Anderson <dianders@...omium.org>
To: alokc@...eaurora.org
Cc: Stephen Boyd <swboyd@...omium.org>,
Dilip Kota <dkota@...eaurora.org>,
Andy Gross <andy.gross@...aro.org>,
David Brown <david.brown@...aro.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: qcom: Add irq clear handling during SE init
Hi,
On Wed, Oct 3, 2018 at 5:24 AM Alok Chauhan <alokc@...eaurora.org> wrote:
>
> when the kernel inits a SE, its quite possible we have pending interrupts
> from bootloaders which did not handle/clear them. So do this in kernel at
> the SE init, to avoid some of it causing bad behavior, while at it also
> club all the register writes needed to clear the se irqs into a function
> to avoid repeating it over.
>
> Signed-off-by: Alok Chauhan <alokc@...eaurora.org>
> ---
> drivers/soc/qcom/qcom-geni-se.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
This looks fine to me. To clarify this doesn't fix any known issues
and it just fixes the theoretical case where somehow a IRQ was sitting
around (maybe left by the firmware) so we want to make really certain
that we start with a clean state at init time.
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists