linux-kernel - [PATCH 1/2] mfd: cros_ec: Do not attempt to register a non-positive IRQ number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20181003184351.148619-1-egranata@google.com>
Date:   Wed,  3 Oct 2018 11:43:51 -0700
From:   Enrico Granata <egranata@...gle.com>
To:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        gwendal@...omium.org
Cc:     Enrico Granata <egranata@...omium.org>,
        Enrico Granata <egranata@...gle.com>
Subject: [PATCH 1/2] mfd: cros_ec: Do not attempt to register a non-positive
 IRQ number

From: Enrico Granata <egranata@...omium.org>

Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.

Signed-off-by: Enrico Granata <egranata@...gle.com>
Signed-off-by: Enrico Granata <egranata@...omium.org>
---
 drivers/mfd/cros_ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index 65a9757a6d21..d6b21e11cad6 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 		return err;
 	}
 
-	if (ec_dev->irq) {
+	if (ec_dev->irq > 0) {
 		err = devm_request_threaded_irq(dev, ec_dev->irq, NULL,
 				ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				"chromeos-ec", ec_dev);
-- 
2.19.0.605.g01d371f741-goog