linux-kernel - Re: [PATCH] ssb: chipcommon: fix fall-through annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181003220435.6f7c27b4@wiggum>
Date:   Wed, 3 Oct 2018 22:04:35 +0200
From:   Michael Büsch <m@...s.ch>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ssb: chipcommon: fix fall-through annotation

On Wed, 3 Oct 2018 14:01:02 +0200
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> Replace "Fallthough" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/ssb/driver_chipcommon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
> index 99a4656..3861cb6 100644
> --- a/drivers/ssb/driver_chipcommon.c
> +++ b/drivers/ssb/driver_chipcommon.c
> @@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
>  			*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
>  			break;
>  		}
> -		/* Fallthough */
> +		/* Fall through */
>  	default:
>  		*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
>  	}

Acked-by: Michael Büsch <m@...s.ch>


-- 
Michael

Content of type "application/pgp-signature" skipped