linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm845: Add UART nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181003225913.GK22824@google.com>
Date:   Wed, 3 Oct 2018 15:59:13 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Add UART nodes

On Wed, Oct 03, 2018 at 03:31:03PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Wed, Oct 3, 2018 at 2:12 PM Matthias Kaehlcke <mka@...omium.org> wrote:
> > +                       uart8: serial@...000 {
> > +                               compatible = "qcom,geni-uart";
> > +                               reg = <0xa80000 0x4000>;
> > +                               clock-names = "se";
> > +                               clocks = <&gcc GCC_QUPV3_WRAP0_S0_CLK>;
> 
> uart8/10/11/12/13/14/15 are on GCC_QUPV3_WRAP1_S0_CLK, not WRAP0.
> 
> Everything else here looks good.  I ran my old hacky script at
> <http://crosreview.com/1091631> (mentioned in the message of commit
> 897cf34e7305 ("arm64: dts: qcom: sdm845: Add I2C, SPI, and UART9
> nodes")) after changing it to generate "qcom,geni-uart" as the
> compatible string and changing it to generate nodes for all UARTs and
> the diff looks fine.
> 
> ...so once you fix the clock reference feel free to add my Reviewed-by.

Thanks for catching this! I'll send out a fixed version soon.