linux-kernel - Re: [PATCH] regulator/mfd: fix pointer-to-int cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181003053939.GE9389@localhost.localdomain>
Date:   Wed, 3 Oct 2018 08:39:39 +0300
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mark Brown <broonie@...nel.org>, Lee Jones <lee.jones@...aro.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator/mfd: fix pointer-to-int cast

Hello Arnd,

On Tue, Oct 02, 2018 at 11:07:32PM +0200, Arnd Bergmann wrote:
> gcc points out that a pointer is longer than an int on 64-bit
> architectures, and that casting between the two may be dangerous:
> 
> drivers/mfd/rohm-bd718x7.c: In function 'bd718xx_i2c_probe':
> drivers/mfd/rohm-bd718x7.c:101:23: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> 
> In this driver it is correct, we just need the right kind of cast
> to avoid the warning.
> 
> Fixes: 494edd266b94 ("regulator/mfd: Support ROHM BD71847 power management IC")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/rohm-bd718x7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index 161c8aac6d86..e66d59190a82 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -98,7 +98,7 @@ static int bd718xx_i2c_probe(struct i2c_client *i2c,
>  		return -ENOMEM;
>  
>  	bd718xx->chip_irq = i2c->irq;
> -	bd718xx->chip_type = (unsigned int)
> +	bd718xx->chip_type = (uintptr_t)
>  				of_device_get_match_data(&i2c->dev);
>  	bd718xx->dev = &i2c->dev;
>  	dev_set_drvdata(&i2c->dev, bd718xx);

Big thanks for this activity =) I also got heads up mail from linux-next
so I also did a patch fixing this. I think Mark alrady applied that
patch to his tree.

(https://lore.kernel.org/lkml/20181002145901.899D41121A41@debutante.sirena.org.uk/)

Br,
	Matti Vaittinen