linux-kernel - Re: [PATCH] rpmsg: glink: smem: Support rx peak for size less than 4 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181004000324.GT2523@minitux>
Date:   Wed, 3 Oct 2018 17:03:24 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Arun Kumar Neelakantam <aneela@...eaurora.org>
Cc:     ohad@...ery.com, clew@...eaurora.org, sricharan@...eaurora.org,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rpmsg: glink: smem: Support rx peak for size less than 4
 bytes

On Wed 03 Oct 04:38 PDT 2018, Arun Kumar Neelakantam wrote:

> The current rx peak function fails to read the data if size is
> less than 4bytes.
> 
> Use memcpy_fromio to support data reads of size less than 4 bytes.
> 
> Signed-off-by: Arun Kumar Neelakantam <aneela@...eaurora.org>

Applied, with a fixes tag and Cc stable.

Thanks,
Bjorn

> ---
>  drivers/rpmsg/qcom_glink_smem.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
> index 2b5cf27..7b65443 100644
> --- a/drivers/rpmsg/qcom_glink_smem.c
> +++ b/drivers/rpmsg/qcom_glink_smem.c
> @@ -89,15 +89,11 @@ static void glink_smem_rx_peak(struct qcom_glink_pipe *np,
>  		tail -= pipe->native.length;
>  
>  	len = min_t(size_t, count, pipe->native.length - tail);
> -	if (len) {
> -		__ioread32_copy(data, pipe->fifo + tail,
> -				len / sizeof(u32));
> -	}
> +	if (len)
> +		memcpy_fromio(data, pipe->fifo + tail, len);
>  
> -	if (len != count) {
> -		__ioread32_copy(data + len, pipe->fifo,
> -				(count - len) / sizeof(u32));
> -	}
> +	if (len != count)
> +		memcpy_fromio(data + len, pipe->fifo, (count - len));
>  }
>  
>  static void glink_smem_rx_advance(struct qcom_glink_pipe *np,
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>